Add key entries for Eisu_toggle and Muhenkan
#818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks sane to me, approving, but going to ask @p12tic to review as well. |
shymega
approved these changes
Jul 28, 2020
|
ping! |
p12tic
approved these changes
Aug 7, 2020
|
@tom-tan Many thanks for the pull request! |
|
Hmm, I've built the latest master but still cannot have |
p12tic
added a commit
to p12tic/barrier
that referenced
this pull request
Jan 10, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request adds key type entries for
Eisu_toggleandMuhenkan, which are used in Japanese keyboards for macOS and Windows computers.It also adds missing entry of
kKeyNameMapforkKeyKana.These keys are important for Japanese input methods that input Japanese characters from alphabets (e.g., "ひらがな" from "hiragana").
HenkanandMuhenkanare used to enable and disable input methods, respectively in Windows computers.Henkanis already available inkey_types.handkey_types.cppKanaandEisu_toggleare used to enable and disable input methods, respectively in macOS computers.Kanais already available inkey_types.hbut not available inkey_types.cppThis request makes easier for Japanese users to share a keyboard between Windows and macOS computers while keeping the functionality of Japanese input methods.
Note: I searched for keysyms for
Eisu_toggleandMuhenkanin the following link: http://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap.